Merge pull request #5257 from aaronraimist/fix-error-code-publicrooms

Fix error code for invalid parameter

2 files changed, 2 insertions, 1 deletions

diff --git a/changelog.d/5257.bugfix b/changelog.d/5257.bugfix
new file mode 100644

index 0000000000..8334af9b99
--- /dev/null
+++ b/changelog.d/5257.bugfix
@@ -0,0 +1 @@
+Fix error code when there is an invalid parameter on /_matrix/client/r0/publicRooms
diff --git a/synapse/http/servlet.py b/synapse/http/servlet.py

index 528125e737..197c652850 100644
--- a/synapse/http/servlet.py
+++ b/synapse/http/servlet.py
@@ -55,7 +55,7 @@ def parse_integer_from_args(args, name, default=None, required=False):
             return int(args[name][0])
         except Exception:
             message = "Query parameter %r must be an integer" % (name,)
-            raise SynapseError(400, message)
+            raise SynapseError(400, message, errcode=Codes.INVALID_PARAM)
     else:
         if required:
             message = "Missing integer query parameter %r" % (name,)