summary refs log tree commit diff
diff options
context:
space:
mode:
authorEric Eastwood <eric.eastwood@beta.gouv.fr>2024-05-16 11:55:51 -0500
committerGitHub <noreply@github.com>2024-05-16 11:55:51 -0500
commit52a649580f34b4f36dfa21abcd05dad27e28bd1a (patch)
treed274a84683b193806326265d80d97f14c0984be6
parentRemoved `request_key` from the `SyncConfig` (moved outside as its own functio... (diff)
downloadsynapse-52a649580f34b4f36dfa21abcd05dad27e28bd1a.tar.xz
Rename to be obvious: `joined_rooms` -> `joined_room_ids` (#17203)
Split out from https://github.com/element-hq/synapse/pull/17167
-rw-r--r--changelog.d/17203.misc1
-rw-r--r--synapse/handlers/sync.py4
2 files changed, 3 insertions, 2 deletions
diff --git a/changelog.d/17203.misc b/changelog.d/17203.misc
new file mode 100644
index 0000000000..142300b1f2
--- /dev/null
+++ b/changelog.d/17203.misc
@@ -0,0 +1 @@
+Rename to be obvious: `joined_rooms` -> `joined_room_ids`.
diff --git a/synapse/handlers/sync.py b/synapse/handlers/sync.py
index 40e42af1f3..6d4373008c 100644
--- a/synapse/handlers/sync.py
+++ b/synapse/handlers/sync.py
@@ -1850,7 +1850,7 @@ class SyncHandler:
 
         users_that_have_changed = set()
 
-        joined_rooms = sync_result_builder.joined_room_ids
+        joined_room_ids = sync_result_builder.joined_room_ids
 
         # Step 1a, check for changes in devices of users we share a room
         # with
@@ -1909,7 +1909,7 @@ class SyncHandler:
         # Remove any users that we still share a room with.
         left_users_rooms = await self.store.get_rooms_for_users(newly_left_users)
         for user_id, entries in left_users_rooms.items():
-            if any(rid in joined_rooms for rid in entries):
+            if any(rid in joined_room_ids for rid in entries):
                 newly_left_users.discard(user_id)
 
         return DeviceListUpdates(changed=users_that_have_changed, left=newly_left_users)