Don't use keyword arguments when initialising modules (#13060)

2 files changed, 2 insertions, 1 deletions

diff --git a/changelog.d/13060.misc b/changelog.d/13060.misc
new file mode 100644

index 0000000000..c2376701f4
--- /dev/null
+++ b/changelog.d/13060.misc
@@ -0,0 +1 @@
+Don't instantiate modules with keyword arguments.
diff --git a/synapse/app/_base.py b/synapse/app/_base.py

index 84e389a6cd..363ac98ea9 100644
--- a/synapse/app/_base.py
+++ b/synapse/app/_base.py
@@ -450,7 +450,7 @@ async def start(hs: "HomeServer") -> None:
     # before we start the listeners.
     module_api = hs.get_module_api()
     for module, config in hs.config.modules.loaded_modules:
-        m = module(config=config, api=module_api)
+        m = module(config, module_api)
         logger.info("Loaded module %s", m)
 
     load_legacy_spam_checkers(hs)