diff options
author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2020-06-25 17:58:55 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-06-25 17:58:55 +0100 |
commit | 177b2d0c19e4127229488ad43d57aba459c719ed (patch) | |
tree | c33a38cf0d63541923e14c1de5c52054bc551b31 | |
parent | Make tox actions work on Debian 10 (#7703) (diff) | |
download | synapse-177b2d0c19e4127229488ad43d57aba459c719ed.tar.xz |
Move flake8 to end. Don't exit script on failure (#7738)
-rw-r--r-- | changelog.d/7738.misc | 1 | ||||
-rwxr-xr-x | scripts-dev/lint.sh | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/changelog.d/7738.misc b/changelog.d/7738.misc new file mode 100644 index 0000000000..424ac15d66 --- /dev/null +++ b/changelog.d/7738.misc @@ -0,0 +1 @@ +Move `flake8` to the end of `scripts-dev/lint.sh` as it takes the longest and could cause the script to exit early. diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh index 34c4854e11..6f1ba22931 100755 --- a/scripts-dev/lint.sh +++ b/scripts-dev/lint.sh @@ -2,8 +2,8 @@ # # Runs linting scripts over the local Synapse checkout # isort - sorts import statements -# flake8 - lints and finds mistakes # black - opinionated code formatter +# flake8 - lints and finds mistakes set -e @@ -16,6 +16,6 @@ fi echo "Linting these locations: $files" isort -y -rc $files -flake8 $files python3 -m black $files ./scripts-dev/config-lint.sh +flake8 $files |