diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2020-10-29 12:16:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-29 12:16:49 +0000 |
| commit | 0073fe914a070c6addc4d76fbe0857ebe96b377e (patch) | |
| tree | 94aaf1cf35dd59172ec0d9ae9f590096258831ee | |
| parent | Optimise createRoom with multiple invites (#8559) (diff) | |
| download | synapse-0073fe914a070c6addc4d76fbe0857ebe96b377e.tar.xz | |
Use `%r` rather than `%s` for stringifying events (#8679)
otherwise non-state events get written as `<FrozenEvent ... state_key='None'>` which is indistinguishable from state events with the actual state_key `None`.
| -rw-r--r-- | changelog.d/8679.misc | 1 | ||||
| -rw-r--r-- | synapse/events/__init__.py | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/changelog.d/8679.misc b/changelog.d/8679.misc new file mode 100644 index 0000000000..662eced4cf --- /dev/null +++ b/changelog.d/8679.misc @@ -0,0 +1 @@ +Clarify representation of events in logfiles. diff --git a/synapse/events/__init__.py b/synapse/events/__init__.py index e203206865..8028663fa8 100644 --- a/synapse/events/__init__.py +++ b/synapse/events/__init__.py @@ -368,7 +368,7 @@ class FrozenEvent(EventBase): return self.__repr__() def __repr__(self): - return "<FrozenEvent event_id='%s', type='%s', state_key='%s'>" % ( + return "<FrozenEvent event_id=%r, type=%r, state_key=%r>" % ( self.get("event_id", None), self.get("type", None), self.get("state_key", None), @@ -451,7 +451,7 @@ class FrozenEventV2(EventBase): return self.__repr__() def __repr__(self): - return "<%s event_id='%s', type='%s', state_key='%s'>" % ( + return "<%s event_id=%r, type=%r, state_key=%r>" % ( self.__class__.__name__, self.event_id, self.get("type", None), |