summary refs log tree commit diff
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2021-06-17 11:21:53 +0100
committerGitHub <noreply@github.com>2021-06-17 11:21:53 +0100
commit52c60bd0a96cd61583209a9ef6d8270425e8a902 (patch)
tree2066cbce54b4b6c291caca5500d4cb7a5ccb54eb
parentImprove comments in the structured logging code. (#10188) (diff)
downloadsynapse-52c60bd0a96cd61583209a9ef6d8270425e8a902.tar.xz
Fix persist_events to stop leaking opentracing contexts (#10193)
-rw-r--r--changelog.d/10193.misc1
-rw-r--r--synapse/storage/persist_events.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/10193.misc b/changelog.d/10193.misc
new file mode 100644
index 0000000000..ce9702645d
--- /dev/null
+++ b/changelog.d/10193.misc
@@ -0,0 +1 @@
+Improve OpenTracing for event persistence.
diff --git a/synapse/storage/persist_events.py b/synapse/storage/persist_events.py
index dc38942bb1..051095fea9 100644
--- a/synapse/storage/persist_events.py
+++ b/synapse/storage/persist_events.py
@@ -111,7 +111,7 @@ class _EventPersistQueueItem:
     backfilled: bool
     deferred: ObservableDeferred
 
-    parent_opentracing_span_contexts: List = []
+    parent_opentracing_span_contexts: List = attr.ib(factory=list)
     """A list of opentracing spans waiting for this batch"""
 
     opentracing_span_context: Any = None