summary refs log tree commit diff
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2019-09-12 13:00:13 +0100
committerGitHub <noreply@github.com>2019-09-12 13:00:13 +0100
commit3d882a7ba52114f18ec6be61c51561db203a0534 (patch)
treed665327f402ef3b7225daa6ce28a67bac916a546
parentFix bug in calculating the federation retry backoff period (#6025) (diff)
downloadsynapse-3d882a7ba52114f18ec6be61c51561db203a0534.tar.xz
Remove the cap on federation retry interval. (#6026)
Essentially the intention here is to end up blacklisting servers which never
respond to federation requests.

Fixes https://github.com/matrix-org/synapse/issues/5113.
-rw-r--r--changelog.d/6026.feature1
-rw-r--r--synapse/util/retryutils.py4
2 files changed, 3 insertions, 2 deletions
diff --git a/changelog.d/6026.feature b/changelog.d/6026.feature
new file mode 100644

index 0000000000..2489ff09b5 --- /dev/null +++ b/changelog.d/6026.feature
@@ -0,0 +1 @@ +Stop sending federation transactions to servers which have been down for a long time. diff --git a/synapse/util/retryutils.py b/synapse/util/retryutils.py
index 33263fe20f..b740913b58 100644 --- a/synapse/util/retryutils.py +++ b/synapse/util/retryutils.py
@@ -28,8 +28,8 @@ MIN_RETRY_INTERVAL = 10 * 60 * 1000 # how much we multiply the backoff by after each subsequent fail RETRY_MULTIPLIER = 5 -# a cap on the backoff -MAX_RETRY_INTERVAL = 24 * 60 * 60 * 1000 +# a cap on the backoff. (Essentially none) +MAX_RETRY_INTERVAL = 2 ** 63 class NotRetryingDestination(Exception):