Pull the _get_event_cache.setdefault() call out of the try block, as it doesn't need to be there and is confusing

1 files changed, 2 insertions, 1 deletions

diff --git a/synapse/storage/_base.py b/synapse/storage/_base.py

index 4b1ec687c9..84f222b3db 100644
--- a/synapse/storage/_base.py
+++ b/synapse/storage/_base.py
@@ -636,8 +636,9 @@ class SQLBaseStore(object):
         start_time = time.time() * 1000
         update_counter = self._get_event_counters.update
 
+        cache = self._get_event_cache.setdefault(event_id, {})
+
         try:
-            cache = self._get_event_cache.setdefault(event_id, {})
             # Separate cache entries for each way to invoke _get_event_txn
             return cache[(check_redacted, get_prev_content, allow_rejected)]
         except KeyError: