summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthew Hodgson <matthew@matrix.org>2014-08-16 13:28:04 +0100
committerMatthew Hodgson <matthew@matrix.org>2014-08-16 13:28:04 +0100
commitdc6212b6fb42fa79086301af1d3e2e43a195b0e5 (patch)
tree432f194602795dce463cc407e2b573f2126804bf
parentorder the members list by most recently active (diff)
downloadsynapse-dc6212b6fb42fa79086301af1d3e2e43a195b0e5.tar.xz
roll back b602834 as it made a bizarre subset of avatars go awol
-rw-r--r--webclient/room/room-controller.js11
1 files changed, 5 insertions, 6 deletions
diff --git a/webclient/room/room-controller.js b/webclient/room/room-controller.js
index 23584f17ae..6cb08dce68 100644
--- a/webclient/room/room-controller.js
+++ b/webclient/room/room-controller.js
@@ -124,18 +124,18 @@ angular.module('RoomController', [])
             if ("mtime_age" in chunk.content) {
                 chunk.mtime_age = chunk.content.mtime_age;
             }
+/*            
+            // FIXME: once the HS reliably returns the displaynames & avatar_urls for both
+            // local and remote users, we should use this rather than the evalAsync block
+            // below
             if ("displayname" in chunk.content) {
                 chunk.displayname = chunk.content.displayname;
             }
             if ("avatar_url" in chunk.content) {
                 chunk.avatar_url = chunk.content.avatar_url;
             }
-        
+ */      
             $scope.members[chunk.target_user_id] = chunk;
-/*
-            // *SURELY* we don't want to be hammering a new request for
-            // every displayname and profile picture URL.  Hasn't it already
-            // been returned in the chunk?  Hence commenting this out --Matthew
 
             // get their display name and profile picture and set it to their
             // member entry in $scope.members. We HAVE to use $timeout with 0 delay 
@@ -160,7 +160,6 @@ angular.module('RoomController', [])
                     }
                 );
             });
-*/            
         }
         else {
             // selectively update membership else it will nuke the picture and displayname too :/