summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erikj@jki.re>2018-10-29 18:16:03 +0000
committerGitHub <noreply@github.com>2018-10-29 18:16:03 +0000
commit00fdfbc21361d67d8cfa3df551592ee4f06f8037 (patch)
treedd83f3a54b5c2c16dbbf47379e5c85375fbfb9ff
parentDelete the disused & unspecced identicon functionality (#4106) (diff)
parentNewsfile (diff)
downloadsynapse-00fdfbc21361d67d8cfa3df551592ee4f06f8037.tar.xz
Merge pull request #4111 from matrix-org/erikj/repl_names
Erikj/repl names
-rw-r--r--changelog.d/4110.misc1
-rw-r--r--synapse/replication/tcp/protocol.py4
2 files changed, 3 insertions, 2 deletions
diff --git a/changelog.d/4110.misc b/changelog.d/4110.misc
new file mode 100644
index 0000000000..a50327ae34
--- /dev/null
+++ b/changelog.d/4110.misc
@@ -0,0 +1 @@
+Fix `synapse_replication_tcp_protocol_*_commands` metric label to be full command name, rather than just the first character
diff --git a/synapse/replication/tcp/protocol.py b/synapse/replication/tcp/protocol.py
index 5dc7b3fffc..0b3fe6cbf5 100644
--- a/synapse/replication/tcp/protocol.py
+++ b/synapse/replication/tcp/protocol.py
@@ -656,7 +656,7 @@ tcp_inbound_commands = LaterGauge(
     "",
     ["command", "name"],
     lambda: {
-        (k[0], p.name,): count
+        (k, p.name,): count
         for p in connected_connections
         for k, count in iteritems(p.inbound_commands_counter)
     },
@@ -667,7 +667,7 @@ tcp_outbound_commands = LaterGauge(
     "",
     ["command", "name"],
     lambda: {
-        (k[0], p.name,): count
+        (k, p.name,): count
         for p in connected_connections
         for k, count in iteritems(p.outbound_commands_counter)
     },