summary refs log tree commit diff
diff options
context:
space:
mode:
authorAmber Brown <hawkowl@atleastfornow.net>2019-07-31 20:39:22 +1000
committerGitHub <noreply@github.com>2019-07-31 20:39:22 +1000
commit8f15832950148280ed5a9cf28b74971abfd09e4f (patch)
tree0221bd5891f1e0b29b47019007b99570505e197c
parentMerge pull request #5796 from matrix-org/erikj/disable_codecov_report (diff)
downloadsynapse-8f15832950148280ed5a9cf28b74971abfd09e4f.tar.xz
Remove DelayedCall debugging from test runs (#5787)
-rw-r--r--changelog.d/5787.misc1
-rw-r--r--tests/unittest.py6
2 files changed, 1 insertions, 6 deletions
diff --git a/changelog.d/5787.misc b/changelog.d/5787.misc
new file mode 100644
index 0000000000..ead0b04b62
--- /dev/null
+++ b/changelog.d/5787.misc
@@ -0,0 +1 @@
+Remove DelayedCall debugging from the test suite, as it is no longer required in the vast majority of Synapse's tests.
diff --git a/tests/unittest.py b/tests/unittest.py
index f5fae21317..561cebc223 100644
--- a/tests/unittest.py
+++ b/tests/unittest.py
@@ -23,8 +23,6 @@ from mock import Mock
 
 from canonicaljson import json
 
-import twisted
-import twisted.logger
 from twisted.internet.defer import Deferred, succeed
 from twisted.python.threadpool import ThreadPool
 from twisted.trial import unittest
@@ -80,10 +78,6 @@ class TestCase(unittest.TestCase):
 
         @around(self)
         def setUp(orig):
-            # enable debugging of delayed calls - this means that we get a
-            # traceback when a unit test exits leaving things on the reactor.
-            twisted.internet.base.DelayedCall.debug = True
-
             # if we're not starting in the sentinel logcontext, then to be honest
             # all future bets are off.
             if LoggingContext.current_context() is not LoggingContext.sentinel: