summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthew Hodgson <matthew@matrix.org>2014-08-22 01:32:17 +0100
committerMatthew Hodgson <matthew@matrix.org>2014-08-22 01:32:17 +0100
commit019f3a66f605222576d4a061df1ecfbaebebf0c0 (patch)
tree6b1d8075b26ad6a1a77bf5fe7b17c2e79aca3516
parenthost a webclient by default (diff)
downloadsynapse-019f3a66f605222576d4a061df1ecfbaebebf0c0.tar.xz
add fixme pointing out name disambiguation is a bit flakey
-rw-r--r--webclient/app-filter.js5
1 files changed, 4 insertions, 1 deletions
diff --git a/webclient/app-filter.js b/webclient/app-filter.js
index f007b4c89c..b8f4ed25bc 100644
--- a/webclient/app-filter.js
+++ b/webclient/app-filter.js
@@ -54,12 +54,15 @@ angular.module('matrixWebClient')
         });
 
         // FIXME: we shouldn't disambiguate displayNames on every orderMembersList
-        // invocation but keep track of duplicates incrementally somewhere            
+        // invocation but keep track of duplicates incrementally somewhere
         angular.forEach(displayNames, function(value, key) {
             if (value.length > 1) {
                 // console.log(key + ": " + value);
                 for (var i=0; i < value.length; i++) {
                     var v = value[i];
+                    // FIXME: this permenantly rewrites the displayname for a given
+                    // room member. which means we can't reset their name if it is
+                    // no longer ambiguous!
                     members[v].displayname += " (" + v + ")";
                     // console.log(v + " " + members[v]);
                 };