diff options
| author | Erik Johnston <erik@matrix.org> | 2019-10-02 16:09:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-02 16:09:02 +0100 |
| commit | 5d8ffdfe6111227bd46a434c33a379fedfa7b78a (patch) | |
| tree | 9799e907b14d8a4ef784db52ee0ba6156ddbef66 | |
| parent | Merge pull request #6152 from matrix-org/erikj/fix_room_list (diff) | |
| parent | Newsfile (diff) | |
| download | synapse-5d8ffdfe6111227bd46a434c33a379fedfa7b78a.tar.xz | |
Merge pull request #6148 from matrix-org/erikj/find_next_generated
Bound find_next_generated_user_id DB query.
| -rw-r--r-- | changelog.d/6148.misc | 1 | ||||
| -rw-r--r-- | synapse/storage/registration.py | 4 |
2 files changed, 4 insertions, 1 deletions
diff --git a/changelog.d/6148.misc b/changelog.d/6148.misc new file mode 100644 index 0000000000..1d5213345c --- /dev/null +++ b/changelog.d/6148.misc @@ -0,0 +1 @@ +Improve performance of `find_next_generated_user_id` DB query. diff --git a/synapse/storage/registration.py b/synapse/storage/registration.py index 241a7be51e..1a859352b6 100644 --- a/synapse/storage/registration.py +++ b/synapse/storage/registration.py @@ -493,7 +493,9 @@ class RegistrationWorkerStore(SQLBaseStore): """ def _find_next_generated_user_id(txn): - txn.execute("SELECT name FROM users") + # We bound between '@1' and '@a' to avoid pulling the entire table + # out. + txn.execute("SELECT name FROM users WHERE '@1' <= name AND name < '@a'") regex = re.compile(r"^@(\d+):") |