diff options
| author | David Robertson <davidr@element.io> | 2022-05-17 19:05:53 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-17 18:05:53 +0000 |
| commit | 0d17357fcdded3fa3f8a37db7b6b9aa0402a10ed (patch) | |
| tree | 8f9d767409ddc3b803079124532b66c99d61663a | |
| parent | Delete events from federation_inbound_events_staging table on purge (#12770) (diff) | |
| download | synapse-0d17357fcdded3fa3f8a37db7b6b9aa0402a10ed.tar.xz | |
Suggest using docker when testing against postgres (#12765)
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
| -rw-r--r-- | changelog.d/12765.doc | 1 | ||||
| -rw-r--r-- | docs/development/contributing_guide.md | 31 |
2 files changed, 29 insertions, 3 deletions
diff --git a/changelog.d/12765.doc b/changelog.d/12765.doc new file mode 100644 index 0000000000..277b037d6b --- /dev/null +++ b/changelog.d/12765.doc @@ -0,0 +1 @@ +Recommend using docker to run tests against postgres. diff --git a/docs/development/contributing_guide.md b/docs/development/contributing_guide.md index d356c72bf7..f55a1fbb90 100644 --- a/docs/development/contributing_guide.md +++ b/docs/development/contributing_guide.md @@ -206,7 +206,32 @@ This means that we need to run our unit tests against PostgreSQL too. Our CI doe this automatically for pull requests and release candidates, but it's sometimes useful to reproduce this locally. -To do so, [configure Postgres](../postgres.md) and run `trial` with the +#### Using Docker + +The easiest way to do so is to run Postgres via a docker container. In one +terminal: + +```shell +docker run --rm -e POSTGRES_PASSWORD=mysecretpassword -e POSTGRES_USER=postgres -e POSTGRES_DB=postgress -p 5432:5432 postgres:14 +``` + +If you see an error like + +``` +docker: Error response from daemon: driver failed programming external connectivity on endpoint nice_ride (b57bbe2e251b70015518d00c9981e8cb8346b5c785250341a6c53e3c899875f1): Error starting userland proxy: listen tcp4 0.0.0.0:5432: bind: address already in use. +``` + +then something is already bound to port 5432. You're probably already running postgres locally. + +Once you have a postgres server running, invoke `trial` in a second terminal: + +```shell +SYNAPSE_POSTGRES=1 SYNAPSE_POSTGRES_HOST=127.0.0.1 SYNAPSE_POSTGRES_USER=postgres SYNAPSE_POSTGRES_PASSWORD=mysecretpassword poetry run trial tests +```` + +#### Using an existing Postgres installation + +If you have postgres already installed on your system, you can run `trial` with the following environment variables matching your configuration: - `SYNAPSE_POSTGRES` to anything nonempty @@ -229,8 +254,8 @@ You don't need to specify the host, user, port or password if your Postgres server is set to authenticate you over the UNIX socket (i.e. if the `psql` command works without further arguments). -Your Postgres account needs to be able to create databases. - +Your Postgres account needs to be able to create databases; see the postgres +docs for [`ALTER ROLE`](https://www.postgresql.org/docs/current/sql-alterrole.html). ## Run the integration tests ([Sytest](https://github.com/matrix-org/sytest)). |