summary refs log tree commit diff
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2023-09-25 15:45:17 +0100
committerGitHub <noreply@github.com>2023-09-25 14:45:17 +0000
commitfad4c63d2528c6b9f1711718a7cc5cdefde665be (patch)
tree8cba2f842f91c57e4dd540f93f5c625b824ebfd8
parentBump sentry-sdk from 1.30.0 to 1.31.0 (#16378) (diff)
downloadsynapse-fad4c63d2528c6b9f1711718a7cc5cdefde665be.tar.xz
Get CI to check PRs have been signed-off (#16348)
-rw-r--r--.github/workflows/tests.yml8
-rw-r--r--changelog.d/16348.misc1
2 files changed, 8 insertions, 1 deletions
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index fb117380d0..b5fffb3653 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -12,6 +12,10 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  check-signoff:
+    if: "github.event_name == 'pull_request'"
+    uses: "matrix-org/backend-meta/.github/workflows/sign-off.yml@v2"
+
   # Job to detect what has changed so we don't run e.g. Rust checks on PRs that
   # don't modify Rust code.
   changes:
@@ -225,6 +229,7 @@ jobs:
       - check-lockfile
       - lint-clippy
       - lint-rustfmt
+      - check-signoff
     runs-on: ubuntu-latest
     steps:
       - run: "true"
@@ -627,9 +632,10 @@ jobs:
         with:
           needs: ${{ toJSON(needs) }}
 
-          # The newsfile lint may be skipped on non PR builds
+          # The newsfile and signoff lints may be skipped on non PR builds
           # Cargo test is skipped if there is no changes on Rust code
           skippable: |
+            check-signoff
             lint-newsfile
             cargo-test
             cargo-bench
diff --git a/changelog.d/16348.misc b/changelog.d/16348.misc
new file mode 100644
index 0000000000..846bb048c8
--- /dev/null
+++ b/changelog.d/16348.misc
@@ -0,0 +1 @@
+Get CI to check PRs have been signed-off.