diff options
author | Patrick Cloke <clokep@users.noreply.github.com> | 2020-12-08 13:41:25 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-12-08 13:41:25 -0500 |
commit | 1a9553045c239160e4c9d6aff1f9adb7fd7d7193 (patch) | |
tree | 8e9440df1b0e2fd66acbe61f67e241a99d30ad44 | |
parent | Minor update to CHANGES. (diff) | |
download | synapse-1a9553045c239160e4c9d6aff1f9adb7fd7d7193.tar.xz |
Fix installing pysaml2 on Python 3.5. (#8898)
This pins pysaml2 to < 6.4.0 on Python 3.5, as the last known working version.
-rw-r--r-- | changelog.d/8898.misc | 1 | ||||
-rw-r--r-- | synapse/python_dependencies.py | 6 |
2 files changed, 6 insertions, 1 deletions
diff --git a/changelog.d/8898.misc b/changelog.d/8898.misc new file mode 100644 index 0000000000..bdb0d40d51 --- /dev/null +++ b/changelog.d/8898.misc @@ -0,0 +1 @@ +Add a maximum version for pysaml2 on Python 3.5. diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py index c899ca14d3..c97e0df1f5 100644 --- a/synapse/python_dependencies.py +++ b/synapse/python_dependencies.py @@ -96,7 +96,11 @@ CONDITIONAL_REQUIREMENTS = { # python 3.5.2, as per https://github.com/itamarst/eliot/issues/418 'eliot<1.8.0;python_version<"3.5.3"', ], - "saml2": ["pysaml2>=4.5.0"], + "saml2": [ + # pysaml2 6.4.0 is incompatible with Python 3.5 (see https://github.com/IdentityPython/pysaml2/issues/749) + "pysaml2>=4.5.0,<6.4.0;python_version<'3.6'", + "pysaml2>=4.5.0;python_version>='3.6'", + ], "oidc": ["authlib>=0.14.0"], "systemd": ["systemd-python>=231"], "url_preview": ["lxml>=3.5.0"], |