diff options
| author | Patrick Cloke <clokep@users.noreply.github.com> | 2023-10-23 07:37:45 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-23 07:37:45 -0400 |
| commit | 12ca87f5eac06450abaf024e5f4906147d5322e3 (patch) | |
| tree | ea7bd5fbe88370ea079b1ace9c565e420988c56d | |
| parent | Bump matrix-synapse-ldap3 from 0.2.2 to 0.3.0 (#16539) (diff) | |
| download | synapse-12ca87f5eac06450abaf024e5f4906147d5322e3.tar.xz | |
Remove the last reference to event_txn_id. (#16521)
This table was no longer used, except for a background process which purged old entries in it.
| -rw-r--r-- | changelog.d/16521.misc | 1 | ||||
| -rw-r--r-- | synapse/storage/databases/main/events_worker.py | 6 | ||||
| -rw-r--r-- | synapse/storage/schema/__init__.py | 5 |
3 files changed, 5 insertions, 7 deletions
diff --git a/changelog.d/16521.misc b/changelog.d/16521.misc new file mode 100644 index 0000000000..c6a8ddcf9c --- /dev/null +++ b/changelog.d/16521.misc @@ -0,0 +1 @@ +Stop deleting from an unused table. diff --git a/synapse/storage/databases/main/events_worker.py b/synapse/storage/databases/main/events_worker.py index 8af638d60f..5bf864c1fb 100644 --- a/synapse/storage/databases/main/events_worker.py +++ b/synapse/storage/databases/main/events_worker.py @@ -2096,12 +2096,6 @@ class EventsWorkerStore(SQLBaseStore): def _cleanup_old_transaction_ids_txn(txn: LoggingTransaction) -> None: one_day_ago = self._clock.time_msec() - 24 * 60 * 60 * 1000 sql = """ - DELETE FROM event_txn_id - WHERE inserted_ts < ? - """ - txn.execute(sql, (one_day_ago,)) - - sql = """ DELETE FROM event_txn_id_device_id WHERE inserted_ts < ? """ diff --git a/synapse/storage/schema/__init__.py b/synapse/storage/schema/__init__.py index 5b50bd66bc..158b528dce 100644 --- a/synapse/storage/schema/__init__.py +++ b/synapse/storage/schema/__init__.py @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -SCHEMA_VERSION = 82 # remember to update the list below when updating +SCHEMA_VERSION = 83 # remember to update the list below when updating """Represents the expectations made by the codebase about the database schema This should be incremented whenever the codebase changes its requirements on the @@ -121,6 +121,9 @@ Changes in SCHEMA_VERSION = 81 Changes in SCHEMA_VERSION = 82 - The insertion_events, insertion_event_extremities, insertion_event_edges, and batch_events tables are no longer purged in preparation for their removal. + +Changes in SCHEMA_VERSION = 83 + - The event_txn_id is no longer used. """ |