diff options
| author | Marcel Krüger <zauguin@gmail.com> | 2019-04-04 13:05:56 +0200 |
|---|---|---|
| committer | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-04-04 12:05:56 +0100 |
| commit | 9f5d206c4a236eb33d6baa70a4838d7391b0254c (patch) | |
| tree | 5ef628f422ad329818e06ff660d80f6a86d9d2e9 | |
| parent | Merge pull request #5004 from ajensenwaud/develop (diff) | |
| download | synapse-9f5d206c4a236eb33d6baa70a4838d7391b0254c.tar.xz | |
Avoid redundant URL encoding (#4555)
* Do not double encode fallback redirect URL Signed-off-by: Marcel Fabian Krüger <zauguin@gmail.com>
| -rw-r--r-- | changelog.d/4555.bugfix | 1 | ||||
| -rw-r--r-- | synapse/static/client/login/js/login.js | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/4555.bugfix b/changelog.d/4555.bugfix new file mode 100644 index 0000000000..d596022c3f --- /dev/null +++ b/changelog.d/4555.bugfix @@ -0,0 +1 @@ +Avoid redundant URL encoding of redirect URL for SSO login in the fallback login page. Fixes a regression introduced in [#4220](https://github.com/matrix-org/synapse/pull/4220). Contributed by Marcel Fabian Krüger ("[zaugin](https://github.com/zauguin)"). diff --git a/synapse/static/client/login/js/login.js b/synapse/static/client/login/js/login.js index 3a958749a1..e02663f50e 100644 --- a/synapse/static/client/login/js/login.js +++ b/synapse/static/client/login/js/login.js @@ -49,7 +49,7 @@ var show_login = function() { $("#loading").hide(); var this_page = window.location.origin + window.location.pathname; - $("#sso_redirect_url").val(encodeURIComponent(this_page)); + $("#sso_redirect_url").val(this_page); if (matrixLogin.serverAcceptsPassword) { $("#password_flow").show(); |