summary refs log tree commit diff
diff options
context:
space:
mode:
authorMathieu Velten <mathieuv@matrix.org>2022-08-03 16:24:44 +0200
committerMathieu Velten <mathieuv@matrix.org>2022-08-03 16:24:44 +0200
commit9b4c0e79d8725cc4fec8b2c780d1bb5b51941a86 (patch)
treeacb5b361cd39a18a259c04695dc45dfba20f4b31
parentApply suggestions from code review (diff)
downloadsynapse-9b4c0e79d8725cc4fec8b2c780d1bb5b51941a86.tar.xz
Adress comments
-rw-r--r--synapse/events/third_party_rules.py9
1 files changed, 4 insertions, 5 deletions
diff --git a/synapse/events/third_party_rules.py b/synapse/events/third_party_rules.py

index 490acd657a..e438f712fd 100644 --- a/synapse/events/third_party_rules.py +++ b/synapse/events/third_party_rules.py
@@ -554,19 +554,18 @@ class ThirdPartyEventRules: was raised at some point. """ - global_changed = True + global_changed = False for callback in self._on_threepid_unbind_callbacks: try: (changed, stop) = await callback( user_id, medium, address, identity_server ) - global_changed &= changed + global_changed |= changed if stop: - return (global_changed, True) + return global_changed, True except Exception as e: logger.exception( "Failed to run module API callback %s: %s", callback, e ) - raise e - return (global_changed, False) + return global_changed, False