diff options
| author | Patrick Cloke <clokep@users.noreply.github.com> | 2023-02-28 10:17:55 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-28 10:17:55 -0500 |
| commit | c369d82df0eac691ccb549051dd61dd77b83d1e9 (patch) | |
| tree | 9e49ef1cb67acf452cfc889db1ea4c78f33817d1 | |
| parent | Do not accept pattern_type from user input in push rules. (#15088) (diff) | |
| download | synapse-c369d82df0eac691ccb549051dd61dd77b83d1e9.tar.xz | |
Add missing type hints to InsecureInterceptableContextFactory. (#15164)
| -rw-r--r-- | changelog.d/15164.misc | 1 | ||||
| -rw-r--r-- | mypy.ini | 3 | ||||
| -rw-r--r-- | synapse/http/client.py | 5 |
3 files changed, 4 insertions, 5 deletions
diff --git a/changelog.d/15164.misc b/changelog.d/15164.misc new file mode 100644 index 0000000000..93ceaeafc9 --- /dev/null +++ b/changelog.d/15164.misc @@ -0,0 +1 @@ +Improve type hints. diff --git a/mypy.ini b/mypy.ini index 94562d0bce..572734f8e7 100644 --- a/mypy.ini +++ b/mypy.ini @@ -36,9 +36,6 @@ exclude = (?x) [mypy-synapse.federation.transport.client] disallow_untyped_defs = False -[mypy-synapse.http.client] -disallow_untyped_defs = False - [mypy-synapse.http.matrixfederationclient] disallow_untyped_defs = False diff --git a/synapse/http/client.py b/synapse/http/client.py index a05f297933..ae48e7c3f0 100644 --- a/synapse/http/client.py +++ b/synapse/http/client.py @@ -44,6 +44,7 @@ from twisted.internet.interfaces import ( IAddress, IDelayedCall, IHostResolution, + IOpenSSLContextFactory, IReactorCore, IReactorPluggableNameResolver, IReactorTime, @@ -958,8 +959,8 @@ class InsecureInterceptableContextFactory(ssl.ContextFactory): self._context = SSL.Context(SSL.SSLv23_METHOD) self._context.set_verify(VERIFY_NONE, lambda *_: False) - def getContext(self, hostname=None, port=None): + def getContext(self) -> SSL.Context: return self._context - def creatorForNetloc(self, hostname: bytes, port: int): + def creatorForNetloc(self, hostname: bytes, port: int) -> IOpenSSLContextFactory: return self |