summary refs log tree commit diff
diff options
context:
space:
mode:
authorShay <hillerys@element.io>2024-07-16 01:52:39 -0700
committerGitHub <noreply@github.com>2024-07-16 09:52:39 +0100
commit899d33f2baf42727fb9b4c118a931d872690a81c (patch)
tree73d2a8f03ec28ab592344df054c34b5201928983
parentFix bug where sync could get stuck when using workers (#17438) (diff)
downloadsynapse-899d33f2baf42727fb9b4c118a931d872690a81c.tar.xz
Remove unnecessary call to resume producing in fake channel (#17449)
This fell out of the authenticated media work - this bit of code masked
a bug but does not break anything when removed, so probably should be
removed.
-rw-r--r--changelog.d/17449.bugfix1
-rw-r--r--tests/server.py4
2 files changed, 1 insertions, 4 deletions
diff --git a/changelog.d/17449.bugfix b/changelog.d/17449.bugfix
new file mode 100644
index 0000000000..cd847a3d1c
--- /dev/null
+++ b/changelog.d/17449.bugfix
@@ -0,0 +1 @@
+Remove unnecessary call to resume producing in fake channel.
\ No newline at end of file
diff --git a/tests/server.py b/tests/server.py
index f1cd0f76be..85602e6953 100644
--- a/tests/server.py
+++ b/tests/server.py
@@ -289,10 +289,6 @@ class FakeChannel:
         self._reactor.run()
 
         while not self.is_finished():
-            # If there's a producer, tell it to resume producing so we get content
-            if self._producer:
-                self._producer.resumeProducing()
-
             if self._reactor.seconds() > end_time:
                 raise TimedOutException("Timed out waiting for request to finish.")