Rename the 'do_users_share_a_room' to something slightly less verb-sounding
4 files changed, 6 insertions, 6 deletions
diff --git a/synapse/handlers/presence.py b/synapse/handlers/presence.py
index 8c1c2bf850..48549b03e5 100644
--- a/synapse/handlers/presence.py
+++ b/synapse/handlers/presence.py
@@ -155,7 +155,7 @@ class PresenceHandler(BaseHandler):
if observer_user == observed_user:
defer.returnValue(True)
- if (yield self.store.do_users_share_a_room(
+ if (yield self.store.user_rooms_intersect(
[observer_user, observed_user]
)):
defer.returnValue(True)
diff --git a/synapse/storage/roommember.py b/synapse/storage/roommember.py
index 2746126e85..c380ec0ebd 100644
--- a/synapse/storage/roommember.py
+++ b/synapse/storage/roommember.py
@@ -165,7 +165,7 @@ class RoomMemberStore(SQLBaseStore):
defer.returnValue(results)
@defer.inlineCallbacks
- def do_users_share_a_room(self, user_list):
+ def user_rooms_intersect(self, user_list):
""" Checks whether a list of users share a room.
"""
user_list_clause = " OR ".join(["m.user_id = ?"] * len(user_list))
diff --git a/tests/handlers/test_presence.py b/tests/handlers/test_presence.py
index b8309bc063..618fb7f270 100644
--- a/tests/handlers/test_presence.py
+++ b/tests/handlers/test_presence.py
@@ -117,10 +117,10 @@ class PresenceStateTestCase(unittest.TestCase):
return defer.succeed([])
room_member_handler.get_room_members = get_room_members
- def do_users_share_a_room(userlist):
+ def user_rooms_intersect(userlist):
shared = all(map(lambda u: u in self.room_members, userlist))
return defer.succeed(shared)
- self.datastore.do_users_share_a_room = do_users_share_a_room
+ self.datastore.user_rooms_intersect = user_rooms_intersect
self.mock_start = Mock()
self.mock_stop = Mock()
diff --git a/tests/handlers/test_presencelike.py b/tests/handlers/test_presencelike.py
index 38cc34350b..638e506d34 100644
--- a/tests/handlers/test_presencelike.py
+++ b/tests/handlers/test_presencelike.py
@@ -107,9 +107,9 @@ class PresenceProfilelikeDataTestCase(unittest.TestCase):
return defer.succeed(self.presence_list)
self.datastore.get_presence_list = get_presence_list
- def do_users_share_a_room(userlist):
+ def user_rooms_intersect(userlist):
return defer.succeed(False)
- self.datastore.do_users_share_a_room = do_users_share_a_room
+ self.datastore.user_rooms_intersect = user_rooms_intersect
self.handlers = hs.get_handlers()
|