diff options
| author | Brendan Abolivier <babolivier@matrix.org> | 2021-02-09 17:50:25 +0100 |
|---|---|---|
| committer | Brendan Abolivier <babolivier@matrix.org> | 2021-02-09 17:50:25 +0100 |
| commit | 29ae04af3b0867642ebae9fa0c2534d4a6c0c975 (patch) | |
| tree | 648bd1aae3281d8299c916e27b4ef4fa4b8c3e96 | |
| parent | Type hints and validation improvements. (#9321) (diff) | |
| download | synapse-29ae04af3b0867642ebae9fa0c2534d4a6c0c975.tar.xz | |
Remove unneeded type constraints on 3rd party protocol lookup responses
| -rw-r--r-- | changelog.d/9361.bugfix | 1 | ||||
| -rw-r--r-- | synapse/appservice/api.py | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/changelog.d/9361.bugfix b/changelog.d/9361.bugfix new file mode 100644 index 0000000000..4d0477f033 --- /dev/null +++ b/changelog.d/9361.bugfix @@ -0,0 +1 @@ +Fix a bug causing Synapse to impose the wrong type constraints on fields when processing responses from appservices to `/_matrix/app/v1/thirdparty/user/{protocol}`. diff --git a/synapse/appservice/api.py b/synapse/appservice/api.py index e366a982b8..11aee50f7a 100644 --- a/synapse/appservice/api.py +++ b/synapse/appservice/api.py @@ -76,9 +76,6 @@ def _is_valid_3pe_result(r, field): fields = r["fields"] if not isinstance(fields, dict): return False - for k in fields.keys(): - if not isinstance(fields[k], str): - return False return True |