summary refs log tree commit diff
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2023-10-24 14:30:09 +0100
committerDavid Robertson <davidr@element.io>2023-10-24 14:30:09 +0100
commiteb810b6f3894e1ea1283dfba25bf14585a3f7358 (patch)
treed49b3732d28eef6a9d7970b6db4e310517d16ab0
parentFix whitespace in help release script help message (diff)
downloadsynapse-github/dmr/release-script-tweaks.tar.xz
Bail out of the release if twine fails github/dmr/release-script-tweaks dmr/release-script-tweaks
-rwxr-xr-xscripts-dev/release.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts-dev/release.py b/scripts-dev/release.py
index bee8761182..02a599667c 100755
--- a/scripts-dev/release.py
+++ b/scripts-dev/release.py
@@ -485,7 +485,7 @@ def _upload(gh_token: Optional[str]) -> None:
             urllib.request.urlretrieve(asset_download_url, filename=filename)
 
         if click.confirm("Upload to PyPI?", default=True):
-            subprocess.run("twine upload *", shell=True, cwd=tmpdir)
+            subprocess.run("twine upload *", shell=True, cwd=tmpdir, check=True)
 
     click.echo(
         f"Done! Remember to merge the tag {tag_name} into the appropriate branches"