Implement workaround for login error.

Signed-off-by: Robert Jacob <xperimental@solidproject.de>

2 files changed, 5 insertions, 1 deletions

diff --git a/changelog.d/4486.bugfix b/changelog.d/4486.bugfix
new file mode 100644

index 0000000000..64588d509b
--- /dev/null
+++ b/changelog.d/4486.bugfix
@@ -0,0 +1 @@
+Workaround for login error when using both LDAP and internal authentication.
diff --git a/synapse/util/logcontext.py b/synapse/util/logcontext.py

index 4c6e92beb8..311b49e18a 100644
--- a/synapse/util/logcontext.py
+++ b/synapse/util/logcontext.py
@@ -285,7 +285,10 @@ class LoggingContext(object):
         self.alive = False
 
         # if we have a parent, pass our CPU usage stats on
-        if self.parent_context is not None:
+        if (
+            self.parent_context is not None
+            and hasattr(self.parent_context, '_resource_usage')
+        ):
             self.parent_context._resource_usage += self._resource_usage
 
             # reset them in case we get entered again