summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erikj@jki.re>2016-06-09 11:22:20 +0100
committerErik Johnston <erikj@jki.re>2016-06-09 11:22:20 +0100
commit2eab219a70c2697a15a60ac9f9d98a4df9eb53cb (patch)
tree9ef1fc42b4e7ebb0368d039030fc82f152916935
parentMerge pull request #859 from matrix-org/erikj/public_room_performance (diff)
parentRemove redundant exception log in /events (diff)
downloadsynapse-2eab219a70c2697a15a60ac9f9d98a4df9eb53cb.tar.xz
Merge pull request #861 from matrix-org/erikj/events_log
Remove redundant exception log in /events
-rw-r--r--synapse/rest/client/v1/events.py45
1 files changed, 21 insertions, 24 deletions
diff --git a/synapse/rest/client/v1/events.py b/synapse/rest/client/v1/events.py

index d1afa0f0d5..498bb9e18a 100644 --- a/synapse/rest/client/v1/events.py +++ b/synapse/rest/client/v1/events.py
@@ -45,30 +45,27 @@ class EventStreamRestServlet(ClientV1RestServlet): raise SynapseError(400, "Guest users must specify room_id param") if "room_id" in request.args: room_id = request.args["room_id"][0] - try: - handler = self.handlers.event_stream_handler - pagin_config = PaginationConfig.from_request(request) - timeout = EventStreamRestServlet.DEFAULT_LONGPOLL_TIME_MS - if "timeout" in request.args: - try: - timeout = int(request.args["timeout"][0]) - except ValueError: - raise SynapseError(400, "timeout must be in milliseconds.") - - as_client_event = "raw" not in request.args - - chunk = yield handler.get_stream( - requester.user.to_string(), - pagin_config, - timeout=timeout, - as_client_event=as_client_event, - affect_presence=(not is_guest), - room_id=room_id, - is_guest=is_guest, - ) - except: - logger.exception("Event stream failed") - raise + + handler = self.handlers.event_stream_handler + pagin_config = PaginationConfig.from_request(request) + timeout = EventStreamRestServlet.DEFAULT_LONGPOLL_TIME_MS + if "timeout" in request.args: + try: + timeout = int(request.args["timeout"][0]) + except ValueError: + raise SynapseError(400, "timeout must be in milliseconds.") + + as_client_event = "raw" not in request.args + + chunk = yield handler.get_stream( + requester.user.to_string(), + pagin_config, + timeout=timeout, + as_client_event=as_client_event, + affect_presence=(not is_guest), + room_id=room_id, + is_guest=is_guest, + ) defer.returnValue((200, chunk))