summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndrew Morgan <andrew@amorgan.xyz>2021-11-24 16:08:49 +0000
committerAndrew Morgan <andrew@amorgan.xyz>2021-11-24 16:08:49 +0000
commitc691ef0992da5ad3b4998a698a39b97acfb81aea (patch)
treed8d6e9fa1ca210a6949a30211359feb17d04d997
parentrename set_type_stream_id_for_appservice -> set_appservice_stream_type_pos (diff)
downloadsynapse-c691ef0992da5ad3b4998a698a39b97acfb81aea.tar.xz
Add some FIXME comments
-rw-r--r--synapse/handlers/appservice.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/synapse/handlers/appservice.py b/synapse/handlers/appservice.py
index c7ef6d2a9c..4a7613b262 100644
--- a/synapse/handlers/appservice.py
+++ b/synapse/handlers/appservice.py
@@ -222,6 +222,7 @@ class ApplicationServicesHandler:
 
         # Notify appservices of updates in ephemeral event streams.
         # Only the following streams are currently supported.
+        # FIXME: We should use constants for these values.
         if stream_key not in (
             "typing_key",
             "receipt_key",
@@ -494,6 +495,8 @@ class ApplicationServicesHandler:
         # Filter out users that this appservice is not interested in
         users_appservice_is_interested_in: List[str] = []
         for user in users:
+            # FIXME: We should do this farther up the call stack. We currently repeat
+            #  this operation in _handle_presence.
             if isinstance(user, UserID):
                 user = user.to_string()