Use TypeError instead of ValueError and give a nicer error mesasge

when someone calls Cache.invalidate with the wrong type.

1 files changed, 3 insertions, 1 deletions

diff --git a/synapse/storage/_base.py b/synapse/storage/_base.py
index e76ee2779a..73eea157a4 100644
--- a/synapse/storage/_base.py
+++ b/synapse/storage/_base.py
@@ -116,7 +116,9 @@ class Cache(object):
     def invalidate(self, key):
         self.check_thread()
         if not isinstance(key, tuple):
-            raise ValueError("keyargs must be a tuple.")
+            raise TypeError(
+                "The cache key must be a tuple not %r" % (type(key),)
+            )
 
         # Increment the sequence number so that any SELECT statements that
         # raced with the INSERT don't update the cache (SYN-369)