summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2017-02-16 15:03:36 +0000
committerErik Johnston <erik@matrix.org>2017-02-16 15:03:36 +0000
commit138e030cfe6e00956d79eed0702ff3f284692357 (patch)
tree6447de67a488ba663073c39452dc4e3adda14785
parentComment (diff)
downloadsynapse-138e030cfe6e00956d79eed0702ff3f284692357.tar.xz
Comment
-rw-r--r--synapse/storage/event_push_actions.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/synapse/storage/event_push_actions.py b/synapse/storage/event_push_actions.py
index ea6722df63..808c9d22fc 100644
--- a/synapse/storage/event_push_actions.py
+++ b/synapse/storage/event_push_actions.py
@@ -36,7 +36,10 @@ def _serialize_action(actions, is_highlight):
     """Custom serializer for actions. This allows us to "compress" common actions.
 
     We use the fact that most users have the same actions for notifs (and for
-    highlights). We replaces these default actions with the emtpy string.
+    highlights).
+    We store these default actions as the empty string rather than the full JSON.
+    Since the empty string isn't valid JSON there is no risk of this clashing with
+    any real JSON actions
     """
     if is_highlight:
         if actions == DEFAULT_HIGHLIGHT_ACTION: