diff options
| author | Brendan Abolivier <babolivier@matrix.org> | 2021-02-09 18:51:44 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-09 18:51:44 +0100 |
| commit | fb0e14ee9a8cfc9962b2e583cf4837e655d9ca5d (patch) | |
| tree | ebae0baf447e3bb217812276b5993ea8b4d4f6e9 | |
| parent | Add XWiki OIDC provider example. (#9324) (diff) | |
| parent | Remove unneeded type constraints on 3rd party protocol lookup responses (diff) | |
| download | synapse-fb0e14ee9a8cfc9962b2e583cf4837e655d9ca5d.tar.xz | |
Merge pull request #9361 from matrix-org/babolivier/third_party_validation
Remove unneeded type constraints on 3rd party protocol lookup responses
| -rw-r--r-- | changelog.d/9361.bugfix | 1 | ||||
| -rw-r--r-- | synapse/appservice/api.py | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/changelog.d/9361.bugfix b/changelog.d/9361.bugfix new file mode 100644 index 0000000000..4d0477f033 --- /dev/null +++ b/changelog.d/9361.bugfix @@ -0,0 +1 @@ +Fix a bug causing Synapse to impose the wrong type constraints on fields when processing responses from appservices to `/_matrix/app/v1/thirdparty/user/{protocol}`. diff --git a/synapse/appservice/api.py b/synapse/appservice/api.py index e366a982b8..11aee50f7a 100644 --- a/synapse/appservice/api.py +++ b/synapse/appservice/api.py @@ -76,9 +76,6 @@ def _is_valid_3pe_result(r, field): fields = r["fields"] if not isinstance(fields, dict): return False - for k in fields.keys(): - if not isinstance(fields[k], str): - return False return True |