Log if we try to do attestations for our own user and group

1 files changed, 8 insertions, 2 deletions

diff --git a/synapse/groups/attestations.py b/synapse/groups/attestations.py

index b751cf5e43..2e252b66a7 100644
--- a/synapse/groups/attestations.py
+++ b/synapse/groups/attestations.py
@@ -130,10 +130,16 @@ class GroupAttestionRenewer(object):
         def _renew_attestation(group_id, user_id):
             attestation = self.attestations.create_attestation(group_id, user_id)
 
-            if self.is_mine_id(group_id):
+            if not self.is_mine_id(group_id):
+                destination = get_domain_from_id(group_id)
+            else not self.is_mine_id(user_id):
                 destination = get_domain_from_id(user_id)
             else:
-                destination = get_domain_from_id(group_id)
+                logger.warn(
+                    "Incorrectly trying to do attestations for user: %r in %r",
+                    user_id, group_id,
+                )
+                return
 
             yield self.transport_client.renew_group_attestation(
                 destination, group_id, user_id,