summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthew Hodgson <matthew@matrix.org>2018-03-13 22:12:15 +0000
committerMatthew Hodgson <matthew@matrix.org>2018-03-13 22:12:15 +0000
commitf0f9a0605b1bddc1b01d1bbb6af93f00763b8496 (patch)
tree9d0816ab0bc5a80635fd958346e03a5244baf7a4
parentmerge proper fix to bug 2969 (diff)
downloadsynapse-f0f9a0605b1bddc1b01d1bbb6af93f00763b8496.tar.xz
remove comment now #2969 is fixed
-rw-r--r--synapse/storage/state.py6
1 files changed, 0 insertions, 6 deletions
diff --git a/synapse/storage/state.py b/synapse/storage/state.py
index 4ab16e18b2..4291cde7ab 100644
--- a/synapse/storage/state.py
+++ b/synapse/storage/state.py
@@ -561,12 +561,6 @@ class StateGroupWorkerStore(SQLBaseStore):
         with matching types. `types` is a list of `(type, state_key)`, where
         a `state_key` of None matches all state_keys. If `types` is None then
         all events are returned.
-
-        XXX: is it really true that `state_key` of None in `types` matches all
-        state_keys? it looks like _get-some_state_from_cache does the right thing,
-        but _get_state_groups_from_groups_txn treats ths None is turned into
-        'AND state_key = NULL' or similar (at least until i just fixed it) --Matthew
-        I've filed this as https://github.com/matrix-org/synapse/issues/2969
         """
         if types:
             types = frozenset(types)