summary refs log tree commit diff
diff options
context:
space:
mode:
authorPatrick Cloke <clokep@users.noreply.github.com>2020-06-12 15:01:00 -0400
committerGitHub <noreply@github.com>2020-06-12 15:01:00 -0400
commit2d11ea385c09e12f38f5927b30919760a158f57a (patch)
treeca62671443e0b78920538911d02439b5dc7efc05
parentFix a typo when comparing the URI & method during UI Auth. (#7689) (diff)
downloadsynapse-2d11ea385c09e12f38f5927b30919760a158f57a.tar.xz
Fix warnings about losing log context during UI auth. (#7688)
-rw-r--r--changelog.d/7688.bugfix1
-rw-r--r--synapse/storage/data_stores/main/ui_auth.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/7688.bugfix b/changelog.d/7688.bugfix
new file mode 100644
index 0000000000..2ed718a087
--- /dev/null
+++ b/changelog.d/7688.bugfix
@@ -0,0 +1 @@
+Fix "Starting db txn 'get_completed_ui_auth_stages' from sentinel context" warning. The bug was introduced in 1.13.0rc1.
diff --git a/synapse/storage/data_stores/main/ui_auth.py b/synapse/storage/data_stores/main/ui_auth.py
index 1d8ee22fb1..ec2f38c373 100644
--- a/synapse/storage/data_stores/main/ui_auth.py
+++ b/synapse/storage/data_stores/main/ui_auth.py
@@ -186,7 +186,7 @@ class UIAuthWorkerStore(SQLBaseStore):
         # The clientdict gets stored as JSON.
         clientdict_json = json.dumps(clientdict)
 
-        self.db.simple_update_one(
+        await self.db.simple_update_one(
             table="ui_auth_sessions",
             keyvalues={"session_id": session_id},
             updatevalues={"clientdict": clientdict_json},