summary refs log tree commit diff
diff options
context:
space:
mode:
authorBrendan Abolivier <babolivier@matrix.org>2022-09-16 18:08:37 +0100
committerBrendan Abolivier <babolivier@matrix.org>2022-09-21 15:46:16 +0100
commitf712904dab95a3d52bfb21bf7e0e4a925b231fee (patch)
tree25c4998567a8c80d5f1257ff98e467ab8cb85727
parentChangelog (diff)
downloadsynapse-f712904dab95a3d52bfb21bf7e0e4a925b231fee.tar.xz
Add a comment explaining why device_id is NULLable
-rw-r--r--synapse/storage/schema/main/delta/73/03pusher_device_id.sql4
1 files changed, 4 insertions, 0 deletions
diff --git a/synapse/storage/schema/main/delta/73/03pusher_device_id.sql b/synapse/storage/schema/main/delta/73/03pusher_device_id.sql
index 442f0abb15..1b4ffbeebe 100644
--- a/synapse/storage/schema/main/delta/73/03pusher_device_id.sql
+++ b/synapse/storage/schema/main/delta/73/03pusher_device_id.sql
@@ -13,4 +13,8 @@
  * limitations under the License.
  */
 
+-- Add a device_id column to track the device ID that created the pusher. It's NULLable
+-- on purpose, because a) it might not be possible to track down the device that created
+-- old pushers (pushers.access_token and access_tokens.device_id are both NULLable), and
+-- b) access tokens retrieved via the admin API don't have a device associated to them.
 ALTER TABLE pushers ADD COLUMN device_id TEXT;
\ No newline at end of file