summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndrew Morgan <1342360+anoadragon453@users.noreply.github.com>2019-09-05 12:16:27 +0100
committerGitHub <noreply@github.com>2019-09-05 12:16:27 +0100
commit07169b110319b23fa32269795472477702bbaee8 (patch)
treed7cdfe36e76f6cfa42cc85767ba3d8ce9620e2cf
parentChange lookup_3pid back to a private method (diff)
downloadsynapse-07169b110319b23fa32269795472477702bbaee8.tar.xz
Apply suggestions from code review
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
-rw-r--r--synapse/handlers/room_member.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/synapse/handlers/room_member.py b/synapse/handlers/room_member.py
index 01f03ad94f..b7fcf969ea 100644
--- a/synapse/handlers/room_member.py
+++ b/synapse/handlers/room_member.py
@@ -724,7 +724,7 @@ class RoomMemberHandler(object):
                 query_params,
             )
             if not isinstance(hash_details, dict):
-                logger.warn(
+                logger.warning(
                     "Got non-dict object when checking hash details of %s: %s",
                     id_server,
                     hash_details,
@@ -739,7 +739,7 @@ class RoomMemberHandler(object):
                 # This is an old identity server that does not yet support v2 lookups
                 use_v1 = True
             else:
-                logger.warn("Error when looking up hashing details: %s" % (e,))
+                logger.warning("Error when looking up hashing details: %s", e)
                 raise e
 
         if use_v1:
@@ -846,7 +846,7 @@ class RoomMemberHandler(object):
                 },
             )
         except Exception as e:
-            logger.warn("Error when performing a v2 3pid lookup: %s" % (e,))
+            logger.warning("Error when performing a v2 3pid lookup: %s", e)
             raise SynapseError(
                 500, "Unknown error occurred during identity server lookup"
             )