summary refs log tree commit diff
diff options
context:
space:
mode:
authorBrendan Abolivier <babolivier@matrix.org>2019-07-10 15:46:42 +0100
committerBrendan Abolivier <babolivier@matrix.org>2019-07-10 15:46:42 +0100
commitf77e99761919db671960aae4792cb563ad2b8e53 (patch)
tree00876cc5b19b0e1ad5143f2a17b1d3067e46a886
parentDon't bundle aggregations when retrieving the original event (#5654) (diff)
downloadsynapse-f77e99761919db671960aae4792cb563ad2b8e53.tar.xz
Send 3PID bind requests as JSON data
-rw-r--r--changelog.d/5656.bugfix1
-rw-r--r--synapse/handlers/identity.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/5656.bugfix b/changelog.d/5656.bugfix
new file mode 100644
index 0000000000..f6ae906a9a
--- /dev/null
+++ b/changelog.d/5656.bugfix
@@ -0,0 +1 @@
+Fix 3PID bind requests being sent to identity servers as `application/x-form-www-urlencoded` data, which is deprecated.
diff --git a/synapse/handlers/identity.py b/synapse/handlers/identity.py
index c82b1933f2..ee6c2c4f8b 100644
--- a/synapse/handlers/identity.py
+++ b/synapse/handlers/identity.py
@@ -118,7 +118,7 @@ class IdentityHandler(BaseHandler):
             raise SynapseError(400, "No client_secret in creds")
 
         try:
-            data = yield self.http_client.post_urlencoded_get_json(
+            data = yield self.http_client.post_post_get_json(
                 "https://%s%s" % (id_server, "/_matrix/identity/api/v1/3pid/bind"),
                 {"sid": creds["sid"], "client_secret": client_secret, "mxid": mxid},
             )