summary refs log tree commit diff
diff options
context:
space:
mode:
authorPatrick Cloke <clokep@users.noreply.github.com>2022-06-07 07:44:31 -0400
committerGitHub <noreply@github.com>2022-06-07 07:44:31 -0400
commitd2fd7f7b5c6adabd1cb323a2107a16bbb3b4506d (patch)
tree7a46bdf7409c6e53c0eba3e813ce72fd5e615c16
parentConsolidate the logic of delete_device/delete_devices. (#12970) (diff)
downloadsynapse-d2fd7f7b5c6adabd1cb323a2107a16bbb3b4506d.tar.xz
Fix a stale comment in get_room_version_id_txn. (#12969)
-rw-r--r--changelog.d/12969.misc1
-rw-r--r--synapse/storage/databases/main/state.py7
2 files changed, 2 insertions, 6 deletions
diff --git a/changelog.d/12969.misc b/changelog.d/12969.misc
new file mode 100644
index 0000000000..05de7ce839
--- /dev/null
+++ b/changelog.d/12969.misc
@@ -0,0 +1 @@
+Fix an inaccurate comment.
diff --git a/synapse/storage/databases/main/state.py b/synapse/storage/databases/main/state.py
index bdd00273cd..5e6efbd0fc 100644
--- a/synapse/storage/databases/main/state.py
+++ b/synapse/storage/databases/main/state.py
@@ -127,13 +127,8 @@ class StateGroupWorkerStore(EventsWorkerStore, SQLBaseStore):
             NotFoundError: if the room is unknown
         """
 
-        # First we try looking up room version from the database, but for old
-        # rooms we might not have added the room version to it yet so we fall
-        # back to previous behaviour and look in current state events.
-        #
         # We really should have an entry in the rooms table for every room we
-        # care about, but let's be a bit paranoid (at least while the background
-        # update is happening) to avoid breaking existing rooms.
+        # care about, but let's be a bit paranoid.
         room_version = self.db_pool.simple_select_one_onecol_txn(
             txn,
             table="rooms",