diff options
| author | Sean Quah <8349537+squahtx@users.noreply.github.com> | 2022-12-12 18:13:43 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-12 18:13:43 +0000 |
| commit | 7982891794e26cabe18448f4e0ec0d301f13d186 (patch) | |
| tree | c0e5865d80dbb21115eda08b5b2d80f70cbd5d29 | |
| parent | Move `StateFilter` to `synapse.types` (#14668) (diff) | |
| download | synapse-7982891794e26cabe18448f4e0ec0d301f13d186.tar.xz | |
Fix missing cache invalidation in application service code (#14670)
#11915 introduced the `@cached` `is_interested_in_room` method in Synapse 1.55.0, which depends upon `get_aliases_for_room`. Add a missing cache invalidation callback so that the `is_interested_in_room` cache is invalidated when `get_aliases_for_room` is invalidated. #13787 made `get_rooms_for_user` `@cached`. Add a missing cache invalidation callback so that the `is_interested_in_presence` cache is invalidated when `get_rooms_for_user` is invalidated. Signed-off-by: Sean Quah <seanq@matrix.org>
| -rw-r--r-- | changelog.d/14670.bugfix | 1 | ||||
| -rw-r--r-- | synapse/appservice/__init__.py | 8 |
2 files changed, 7 insertions, 2 deletions
diff --git a/changelog.d/14670.bugfix b/changelog.d/14670.bugfix new file mode 100644 index 0000000000..98398d76cc --- /dev/null +++ b/changelog.d/14670.bugfix @@ -0,0 +1 @@ +Fix bugs introduced in 1.55.0 and 1.69.0 where application services would not be notified of events in the correct rooms, due to stale caches. diff --git a/synapse/appservice/__init__.py b/synapse/appservice/__init__.py index bf4e6c629b..65615f50b8 100644 --- a/synapse/appservice/__init__.py +++ b/synapse/appservice/__init__.py @@ -245,7 +245,9 @@ class ApplicationService: return True # likewise with the room's aliases (if it has any) - alias_list = await store.get_aliases_for_room(room_id) + alias_list = await store.get_aliases_for_room( + room_id, on_invalidate=cache_context.invalidate + ) for alias in alias_list: if self.is_room_alias_in_namespace(alias): return True @@ -311,7 +313,9 @@ class ApplicationService: # Find all the rooms the sender is in if self.is_interested_in_user(user_id.to_string()): return True - room_ids = await store.get_rooms_for_user(user_id.to_string()) + room_ids = await store.get_rooms_for_user( + user_id.to_string(), on_invalidate=cache_context.invalidate + ) # Then find out if the appservice is interested in any of those rooms for room_id in room_ids: |