summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndrew Morgan <andrew@amorgan.xyz>2020-09-18 10:58:14 +0100
committerAndrew Morgan <andrew@amorgan.xyz>2020-09-18 10:58:14 +0100
commitbbd04152c9190d55d614be5827552963ffdcc7d8 (patch)
tree58488ff0ab45620d977467a5a5664f962ca3602d
parentLog pdus (diff)
downloadsynapse-anoa/morgan.software.tar.xz
-rw-r--r--synapse/federation/federation_client.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py
index 68f8ffaed3..585837341e 100644
--- a/synapse/federation/federation_client.py
+++ b/synapse/federation/federation_client.py
@@ -217,11 +217,11 @@ class FederationClient(FederationBase):
             for p in transaction_data["pdus"]
         ]
 
-        # FIXME: We should handle signature failures more gracefully.
-        pdus[:] = await make_deferred_yieldable(
-            defer.gatherResults(
-                self._check_sigs_and_hashes(room_version, pdus), consumeErrors=True,
-            ).addErrback(unwrapFirstError)
+        pdus[:] = await self._check_sigs_and_hash_and_fetch(
+            dest,
+            list(pdus),
+            outlier=True,
+            room_version=room_version,
         )
 
         logger.info("DDD pdus ended up as: %s", pdus)