summary refs log tree commit diff
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2020-12-15 15:18:03 +0000
committerRichard van der Hoff <richard@matrix.org>2020-12-15 22:35:03 +0000
commitac2acf1524ea33a37b5cdbd4cebcb149c80a48c7 (patch)
tree1e4ce1f671d1f9a2172783765af9c1dbf0623bf5
parentSkip redundant check on `request.args` (diff)
downloadsynapse-ac2acf1524ea33a37b5cdbd4cebcb149c80a48c7.tar.xz
Remove redundant reading of SynapseRequest.args
this didn't seem to be doing a lot, so remove it.
Diffstat (limited to '')
-rw-r--r--tests/rest/client/v2_alpha/test_account.py10
1 files changed, 1 insertions, 9 deletions
diff --git a/tests/rest/client/v2_alpha/test_account.py b/tests/rest/client/v2_alpha/test_account.py
index 11a042f9e9..8a898be24c 100644
--- a/tests/rest/client/v2_alpha/test_account.py
+++ b/tests/rest/client/v2_alpha/test_account.py
@@ -19,7 +19,6 @@ import os
 import re
 from email.parser import Parser
 from typing import Optional
-from urllib.parse import urlencode
 
 import pkg_resources
 
@@ -268,20 +267,13 @@ class PasswordResetTestCase(unittest.HomeserverTestCase):
         # Now POST to the same endpoint, mimicking the same behaviour as clicking the
         # password reset confirm button
 
-        # Send arguments as url-encoded form data, matching the template's behaviour
-        form_args = []
-        for key, value_list in request.args.items():
-            for value in value_list:
-                arg = (key, value)
-                form_args.append(arg)
-
         # Confirm the password reset
         request, channel = make_request(
             self.reactor,
             FakeSite(self.submit_token_resource),
             "POST",
             path,
-            content=urlencode(form_args).encode("utf8"),
+            content=b"",
             shorthand=False,
             content_is_form=True,
         )