summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2021-05-06 14:06:06 +0100
committerGitHub <noreply@github.com>2021-05-06 14:06:06 +0100
commit24f07a83e604a7ee93214ef0bf7d7c56a14a534d (patch)
treec644901962c64dafb7529a798dc2e77b899a7459
parent 1.33.0 (diff)
downloadsynapse-24f07a83e604a7ee93214ef0bf7d7c56a14a534d.tar.xz
Pin attrs to <21.1.0 (#9937)
Fixes #9936
Diffstat (limited to '')
-rw-r--r--changelog.d/9937.bugfix1
-rw-r--r--synapse/python_dependencies.py3
2 files changed, 3 insertions, 1 deletions
diff --git a/changelog.d/9937.bugfix b/changelog.d/9937.bugfix
new file mode 100644
index 0000000000..c1cc5ccb43
--- /dev/null
+++ b/changelog.d/9937.bugfix
@@ -0,0 +1 @@
+Fix bug where `/sync` would break if using the latest version of `attrs` dependency, by pinning to a previous version.
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
index 2de946f464..7709361f16 100644
--- a/synapse/python_dependencies.py
+++ b/synapse/python_dependencies.py
@@ -78,7 +78,8 @@ REQUIREMENTS = [
     # we use attr.validators.deep_iterable, which arrived in 19.1.0 (Note:
     # Fedora 31 only has 19.1, so if we want to upgrade we should wait until 33
     # is out in November.)
-    "attrs>=19.1.0",
+    # Note: 21.1.0 broke `/sync`, see #9936
+    "attrs>=19.1.0,<21.1.0",
     "netaddr>=0.7.18",
     "Jinja2>=2.9",
     "bleach>=1.4.3",