summary refs log tree commit diff
diff options
context:
space:
mode:
authorPatrick Cloke <clokep@users.noreply.github.com>2020-06-12 14:12:04 -0400
committerGitHub <noreply@github.com>2020-06-12 14:12:04 -0400
commitd0a43d431ec3ab7603827d26924b3708a5bc33b2 (patch)
treeb6050eacb78b03bad8a1c3fdd638e97650d3182e
parentRemove "user_id" from GET /presence. (#7606) (diff)
downloadsynapse-d0a43d431ec3ab7603827d26924b3708a5bc33b2.tar.xz
Fix a typo when comparing the URI & method during UI Auth. (#7689)
Diffstat (limited to '')
-rw-r--r--changelog.d/7689.bugfix1
-rw-r--r--synapse/handlers/auth.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/7689.bugfix b/changelog.d/7689.bugfix
new file mode 100644
index 0000000000..10ad4c8c13
--- /dev/null
+++ b/changelog.d/7689.bugfix
@@ -0,0 +1 @@
+Compare the URI and method during user interactive authentication (instead of the URI twice). Bug introduced in 1.13.0rc1.
diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py
index 119678e67b..b01124fe42 100644
--- a/synapse/handlers/auth.py
+++ b/synapse/handlers/auth.py
@@ -297,7 +297,7 @@ class AuthHandler(BaseHandler):
 
         # Convert the URI and method to strings.
         uri = request.uri.decode("utf-8")
-        method = request.uri.decode("utf-8")
+        method = request.method.decode("utf-8")
 
         # If there's no session ID, create a new session.
         if not sid: