summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2017-01-31 15:21:32 +0000
committerErik Johnston <erik@matrix.org>2017-01-31 15:21:32 +0000
commitfe08db2713cb35e1424034d58d750ebdc52cedbc (patch)
tree3594a867d5b9911c163abf099789caec0503d572
parentComment (diff)
downloadsynapse-fe08db2713cb35e1424034d58d750ebdc52cedbc.tar.xz
Remove explicit < 400 check as apparently this is confusing
Diffstat (limited to '')
-rw-r--r--synapse/util/retryutils.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/synapse/util/retryutils.py b/synapse/util/retryutils.py
index 5c7fc1afb4..b94ae369cf 100644
--- a/synapse/util/retryutils.py
+++ b/synapse/util/retryutils.py
@@ -129,9 +129,7 @@ class RetryDestinationLimiter(object):
             # APIs may expect to never received e.g. a 404. It's important to
             # handle 404 as some remote servers will return a 404 when the HS
             # has been decommissioned.
-            if exc_val.code < 400:
-                valid_err_code = True
-            elif exc_val.code == 404 and self.backoff_on_404:
+            if exc_val.code == 404 and self.backoff_on_404:
                 valid_err_code = False
             elif exc_val.code == 429:
                 # 429 is us being aggresively rate limited, so lets rate limit