diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2020-09-08 14:52:51 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-08 14:52:51 +0100 |
| commit | 703e2b8a960a0845a5fbe14c34c45ae802300a4d (patch) | |
| tree | 432acb98e68cf0ee5a9d3dbd52da9713413c63e7 | |
| parent | Fix `MultiWriterIdGenerator.current_position`. (#8257) (diff) | |
| download | synapse-703e2b8a960a0845a5fbe14c34c45ae802300a4d.tar.xz | |
Use the right constructor for log records (#8278)
Update `log_function` to use the right factory to create log records, to make sure that they have `request` attributes. Fixes: #8267.
Diffstat (limited to '')
| -rw-r--r-- | changelog.d/8278.bugfix | 1 | ||||
| -rw-r--r-- | synapse/logging/utils.py | 6 |
2 files changed, 4 insertions, 3 deletions
diff --git a/changelog.d/8278.bugfix b/changelog.d/8278.bugfix new file mode 100644 index 0000000000..50e40ca2a9 --- /dev/null +++ b/changelog.d/8278.bugfix @@ -0,0 +1 @@ +Fix a bug which cause the logging system to report errors, if `DEBUG` was enabled and no `context` filter was applied. diff --git a/synapse/logging/utils.py b/synapse/logging/utils.py index fea774e2e5..becf66dd86 100644 --- a/synapse/logging/utils.py +++ b/synapse/logging/utils.py @@ -29,11 +29,11 @@ def _log_debug_as_f(f, msg, msg_args): lineno = f.__code__.co_firstlineno pathname = f.__code__.co_filename - record = logging.LogRecord( + record = logger.makeRecord( name=name, level=logging.DEBUG, - pathname=pathname, - lineno=lineno, + fn=pathname, + lno=lineno, msg=msg, args=msg_args, exc_info=None, |