summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erikj@jki.re>2016-09-06 10:57:48 +0100
committerGitHub <noreply@github.com>2016-09-06 10:57:48 +0100
commit2eed4d7af4b3db40a675b12a8af9cbd52ad85655 (patch)
treef8ed6e4a30287c6bc6230a4534e7e6c10050098e
parentMerge pull request #1071 from matrix-org/erikj/pdf_fix (diff)
parentShort circuit if presence is the same (diff)
downloadsynapse-2eed4d7af4b3db40a675b12a8af9cbd52ad85655.tar.xz
Merge pull request #1072 from matrix-org/erikj/presence_fiddle
Fiddle should_notify to better report stats
Diffstat (limited to '')
-rw-r--r--synapse/handlers/presence.py22
1 files changed, 10 insertions, 12 deletions
diff --git a/synapse/handlers/presence.py b/synapse/handlers/presence.py
index 7ae05603f5..a9f5233119 100644
--- a/synapse/handlers/presence.py
+++ b/synapse/handlers/presence.py
@@ -941,33 +941,31 @@ class PresenceHandler(object):
 def should_notify(old_state, new_state):
     """Decides if a presence state change should be sent to interested parties.
     """
+    if old_state == new_state:
+        return False
+
     if old_state.status_msg != new_state.status_msg:
         notify_reason_counter.inc("status_msg_change")
         return True
 
-    if old_state.state == PresenceState.ONLINE:
-        if new_state.state != PresenceState.ONLINE:
-            # Always notify for online -> anything
-            notify_reason_counter.inc("online_to_not")
-            return True
+    if old_state.state != new_state.state:
+        notify_reason_counter.inc("state_change")
+        return True
 
+    if old_state.state == PresenceState.ONLINE:
         if new_state.currently_active != old_state.currently_active:
             notify_reason_counter.inc("current_active_change")
             return True
 
         if new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
             # Only notify about last active bumps if we're not currently acive
-            if not (old_state.currently_active and new_state.currently_active):
-                notify_reason_counter.inc("last_active_change")
+            if not new_state.currently_active:
+                notify_reason_counter.inc("last_active_change_online")
                 return True
 
     elif new_state.last_active_ts - old_state.last_active_ts > LAST_ACTIVE_GRANULARITY:
         # Always notify for a transition where last active gets bumped.
-        notify_reason_counter.inc("last_active_change")
-        return True
-
-    if old_state.state != new_state.state:
-        notify_reason_counter.inc("state_change")
+        notify_reason_counter.inc("last_active_change_not_online")
         return True
 
     return False