summary refs log tree commit diff
diff options
context:
space:
mode:
authorSean Quah <8349537+squahtx@users.noreply.github.com>2021-10-05 12:23:25 +0100
committerGitHub <noreply@github.com>2021-10-05 12:23:25 +0100
commit660c8c1415704f0b9c6fe17fe74d40dfefd78f0a (patch)
tree4289eea8c281097b4e79f49fe1de8494612640da
parentAdd functionality to remove deactivated users from the monthly_active_users t... (diff)
downloadsynapse-660c8c1415704f0b9c6fe17fe74d40dfefd78f0a.tar.xz
Log stack traces when a missing opentracing span is detected (#10983)
Make it easier to track down where opentracing spans are going missing
by including stack traces in the logs.
Diffstat (limited to '')
-rw-r--r--changelog.d/10983.misc1
-rw-r--r--synapse/logging/opentracing.py1
2 files changed, 2 insertions, 0 deletions
diff --git a/changelog.d/10983.misc b/changelog.d/10983.misc
new file mode 100644
index 0000000000..235899d14f
--- /dev/null
+++ b/changelog.d/10983.misc
@@ -0,0 +1 @@
+Log stack traces when a missing opentracing span is detected.
diff --git a/synapse/logging/opentracing.py b/synapse/logging/opentracing.py
index 03d2dd94f6..5276c4bfcc 100644
--- a/synapse/logging/opentracing.py
+++ b/synapse/logging/opentracing.py
@@ -339,6 +339,7 @@ def ensure_active_span(message, ret=None):
                     "There was no active span when trying to %s."
                     " Did you forget to start one or did a context slip?",
                     message,
+                    stack_info=True,
                 )
 
                 return ret