summary refs log tree commit diff
diff options
context:
space:
mode:
authorDenis Kasak <dkasak@termina.org.uk>2021-03-31 12:27:20 +0000
committerGitHub <noreply@github.com>2021-03-31 12:27:20 +0000
commit5ff8eb97c646f9f8de74915e4b2926789695d4af (patch)
treeda32c10f0ddc02a30905f436d41a221fe301f87f
parentDeprecate imp (#9718) (diff)
downloadsynapse-5ff8eb97c646f9f8de74915e4b2926789695d4af.tar.xz
Make sample config allowed_local_3pids regex stricter. (#9719)
The regex should be terminated so that subdomain matches of another
domain are not accepted. Just ensuring that someone doesn't shoot
themselves in the foot by copying our example.

Signed-off-by: Denis Kasak <dkasak@termina.org.uk>
Diffstat (limited to '')
-rw-r--r--changelog.d/9719.doc1
-rw-r--r--docs/sample_config.yaml4
-rw-r--r--synapse/config/registration.py4
3 files changed, 5 insertions, 4 deletions
diff --git a/changelog.d/9719.doc b/changelog.d/9719.doc
new file mode 100644
index 0000000000..f018606dd6
--- /dev/null
+++ b/changelog.d/9719.doc
@@ -0,0 +1 @@
+Make the allowed_local_3pids regex example in the sample config stricter.
diff --git a/docs/sample_config.yaml b/docs/sample_config.yaml
index c73ea6b161..b0bf987740 100644
--- a/docs/sample_config.yaml
+++ b/docs/sample_config.yaml
@@ -1246,9 +1246,9 @@ account_validity:
 #
 #allowed_local_3pids:
 #  - medium: email
-#    pattern: '.*@matrix\.org'
+#    pattern: '^[^@]+@matrix\.org$'
 #  - medium: email
-#    pattern: '.*@vector\.im'
+#    pattern: '^[^@]+@vector\.im$'
 #  - medium: msisdn
 #    pattern: '\+44'
 
diff --git a/synapse/config/registration.py b/synapse/config/registration.py
index ead007ba5a..f27d1e14ac 100644
--- a/synapse/config/registration.py
+++ b/synapse/config/registration.py
@@ -298,9 +298,9 @@ class RegistrationConfig(Config):
         #
         #allowed_local_3pids:
         #  - medium: email
-        #    pattern: '.*@matrix\\.org'
+        #    pattern: '^[^@]+@matrix\\.org$'
         #  - medium: email
-        #    pattern: '.*@vector\\.im'
+        #    pattern: '^[^@]+@vector\\.im$'
         #  - medium: msisdn
         #    pattern: '\\+44'