summary refs log tree commit diff
diff options
context:
space:
mode:
authorEric Eastwood <erice@element.io>2023-05-16 08:56:42 -0500
committerGitHub <noreply@github.com>2023-05-16 14:56:42 +0100
commitb6a7d49b6f1f7c494372fd1b9aab3982c9a299c7 (patch)
tree7cdd81a04740f4ff86bf55a1421dc0577a63c866
parentTweak changelog (diff)
downloadsynapse-b6a7d49b6f1f7c494372fd1b9aab3982c9a299c7.tar.xz
`traceback.format_exception(...)` usage that is compatible with Python 3.7 and 3.11 (#15599)
* Usage that is compatible with Python 3.8 and 3.11

> Since Python 3.10, instead of passing value and tb, an exception object can
  be passed as the first argument. If value and tb are provided, the first
  argument is ignored in order to provide backwards compatibility.
>
> -- https://docs.python.org/3/library/traceback.html

* Add changelog
Diffstat (limited to '')
-rw-r--r--changelog.d/15599.bugfix1
-rw-r--r--synapse/app/_base.py2
2 files changed, 2 insertions, 1 deletions
diff --git a/changelog.d/15599.bugfix b/changelog.d/15599.bugfix
new file mode 100644
index 0000000000..b58af8ad55
--- /dev/null
+++ b/changelog.d/15599.bugfix
@@ -0,0 +1 @@
+Print full error and stack-trace of any exception that occurs during startup/initialization.
diff --git a/synapse/app/_base.py b/synapse/app/_base.py
index 4dfcf484fa..936b1b0430 100644
--- a/synapse/app/_base.py
+++ b/synapse/app/_base.py
@@ -214,7 +214,7 @@ def handle_startup_exception(e: Exception) -> NoReturn:
     # the reactor are written to the logs, followed by a summary to stderr.
     logger.exception("Exception during startup")
 
-    error_string = "".join(traceback.format_exception(e))
+    error_string = "".join(traceback.format_exception(type(e), e, e.__traceback__))
     indented_error_string = indent(error_string, "    ")
 
     quit_with_error(