Actually use the picture_claim as configured in OIDC config. (#14751)

Previously it was only using the default value ("picture") when
fetching the picture from the user info.

2 files changed, 2 insertions, 1 deletions

diff --git a/changelog.d/14751.bugfix b/changelog.d/14751.bugfix
new file mode 100644

index 0000000000..56ef852288
--- /dev/null
+++ b/changelog.d/14751.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse 1.73.0 where the `picture_claim` configured under `oidc_providers` was unused (the default value of `"picture"` was used instead).
diff --git a/synapse/handlers/oidc.py b/synapse/handlers/oidc.py

index 03de6a4ba6..23fb00c9c9 100644
--- a/synapse/handlers/oidc.py
+++ b/synapse/handlers/oidc.py
@@ -1615,7 +1615,7 @@ class JinjaOidcMappingProvider(OidcMappingProvider[JinjaOidcMappingConfig]):
         if email:
             emails.append(email)
 
-        picture = userinfo.get("picture")
+        picture = userinfo.get(self._config.picture_claim)
 
         return UserAttributeDict(
             localpart=localpart,