summary refs log tree commit diff
path: root/.github
diff options
context:
space:
mode:
authorDavid Robertson <david.m.robertson1@gmail.com>2021-08-10 12:15:10 +0100
committerDavid Robertson <david.m.robertson1@gmail.com>2021-08-10 16:38:13 +0100
commit03fb99a5c8dbe67cf300986e76ea0e8183641211 (patch)
tree6f97f3b34e1a2f5b15578b7e5a92138f69473246 /.github
parentMove test_old_deps.sh to new ci dir (diff)
downloadsynapse-03fb99a5c8dbe67cf300986e76ea0e8183641211.tar.xz
check-newsfragment: pass pr number explicitly
use PULL_REQUEST_NUMBER instead of BUILDKITE_PULL_REQUEST
remove the other user of BUILDKITE_PULL_REQUEST, namely merge_base_branch.sh
Diffstat (limited to '.github')
-rw-r--r--.github/workflows/tests.yml6
1 files changed, 2 insertions, 4 deletions
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 8612d1fb3a..5349e83133 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -47,11 +47,9 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-python@v2
       - run: pip install tox
-      - name: Patch Buildkite-specific test script
-        run: |
-          sed -i -e 's/\$BUILDKITE_PULL_REQUEST/${{ github.event.number }}/' \
-            scripts-dev/check-newsfragment
       - run: scripts-dev/check-newsfragment
+        env:
+          PULL_REQUEST_NUMBER: ${{ github.event.number }}
 
   lint-sdist:
     runs-on: ubuntu-latest